Cadoles
/
BeSimpleSoap
20
0
Fork 0
Code Issues 1 Pull Requests Projects Releases Wiki Activity

Fixed MessageBinder to avoid BC Break

This commit is contained in:
Francis Besset 2013-02-21 08:13:40 +01:00
parent b4900b95c5
commit 2b60cec190
1 changed files with 8 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
src/BeSimple/SoapCommon/Util/MessageBinder.php
View File

@ -61,16 +61,15 @@ class MessageBinder
// needed to support magic method __get // needed to support magic method __get
$value = $this->message->{$property}; $value = $this->message->{$property};
} elseif ($this->reflectionClass->hasProperty($property)) { } elseif ($this->reflectionClass->hasProperty($property)) {
if (!$this->reflectionClass->getProperty($property)->isPublic()) { $p = $this->reflectionClass->getProperty($property);
throw new \RuntimeException(sprintf('Property "%s" is not public in class "%s". Maybe you should create the method "%s()" or "%s()" or "%s()"?', $property, $this->reflectionClass->name, $getter, $isser, $hasser)); if (!$p->isPublic()) {
$p->setAccessible(true);
} }
$value = $this->message->{$property}; $value = $p->getValue($this->message);
} elseif (property_exists($this->message, $property)) { } elseif (property_exists($this->message, $property)) {
// needed to support \stdClass instances // needed to support \stdClass instances
$value = $this->message->{$property}; $value = $this->message->{$property};
} else {
throw new \RuntimeException(sprintf('Neither property "%s" nor method "%s()" nor method "%s()" exists in class "%s"', $property, $getter, $isser, $this->reflectionClass->name));
} }
return $value; return $value;
@ -88,16 +87,15 @@ class MessageBinder
// needed to support magic method __set // needed to support magic method __set
$this->message->{$property} = $value; $this->message->{$property} = $value;
} elseif ($this->reflectionClass->hasProperty($property)) { } elseif ($this->reflectionClass->hasProperty($property)) {
if (!$this->reflectionClass->getProperty($property)->isPublic()) { $p = $this->reflectionClass->getProperty($property);
throw new \RuntimeException(sprintf('Property "%s" is not public in class "%s". Maybe you should create the method "%s()"?', $property, $this->reflectionClass->name, $setter)); if (!$p->isPublic()) {
$p->setAccessible(true);
} }
$this->message->{$property} = $value; $p->setValue($this->message, $value);
} elseif (property_exists($this->message, $property)) { } elseif (property_exists($this->message, $property)) {
// needed to support \stdClass instances // needed to support \stdClass instances
$this->message->{$property} = $value; $this->message->{$property} = $value;
} else {
throw new \RuntimeException(sprintf('Neither element "%s" nor method "%s()" exists in class "%s"', $property, $setter, $this->reflectionClass->name));
} }
} }
} }