Cadoles
/
BeSimpleSoap
20
0
Fork 0
Code Issues 1 Pull Requests Projects Releases Wiki Activity

Refactored SoapWebServiceController

This commit is contained in:
Francis Besset 2013-02-21 08:27:36 +01:00
parent 794d6cf8c2
commit 03f19a0e61
1 changed files with 22 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

40
Controller/SoapWebServiceController.php
View File

@ -1,8 +1,10 @@
<?php <?php
/* /*
* This file is part of the BeSimpleSoapBundle. * This file is part of the BeSimpleSoapBundle.
* *
* (c) Christian Kerl <christian-kerl@web.de> * (c) Christian Kerl <christian-kerl@web.de>
* (c) Francis Besset <francis.besset@gmail.com>
* *
* This source file is subject to the MIT license that is bundled * This source file is subject to the MIT license that is bundled
* with this source code in the file LICENSE. * with this source code in the file LICENSE.
@ -20,6 +22,7 @@ use Symfony\Component\HttpKernel\HttpKernelInterface;
/** /**
* @author Christian Kerl <christian-kerl@web.de> * @author Christian Kerl <christian-kerl@web.de>
* @author Francis Besset <francis.besset@gmail.com>
*/ */
class SoapWebServiceController extends ContainerAware class SoapWebServiceController extends ContainerAware
{ {
@ -66,9 +69,8 @@ class SoapWebServiceController extends ContainerAware
ob_start(); ob_start();
$this->soapServer->handle($this->soapRequest->getSoapMessage()); $this->soapServer->handle($this->soapRequest->getSoapMessage());
$this->getResponse()->setContent(ob_get_clean());
return $this->getResponse(); return $this->getResponse()->setContent(ob_get_clean());
} }
/** /**
@ -84,8 +86,8 @@ class SoapWebServiceController extends ContainerAware
) )
)); ));
$request = $this->container->get('request'); $query = $this->container->get('request')->query;
if ($request->query->has('wsdl') || $request->query->has('WSDL')) { if ($query->has('wsdl') || $query->has('WSDL')) {
$response->headers->set('Content-Type', 'application/wsdl+xml'); $response->headers->set('Content-Type', 'application/wsdl+xml');
} else { } else {
$response->headers->set('Content-Type', 'text/xml'); $response->headers->set('Content-Type', 'text/xml');
@ -127,17 +129,17 @@ class SoapWebServiceController extends ContainerAware
throw $e; throw $e;
} }
$this->soapResponse = $this->checkResponse($response); $this->setResponse($response);
// add response soap headers to soap server // add response soap headers to soap server
foreach ($this->getResponse()->getSoapHeaders() as $header) { foreach ($response->getSoapHeaders() as $header) {
$this->soapServer->addSoapHeader($header->toNativeSoapHeader()); $this->soapServer->addSoapHeader($header->toNativeSoapHeader());
} }
// return operation return value to soap server // return operation return value to soap server
return $this->serviceBinder->processServiceMethodReturnValue( return $this->serviceBinder->processServiceMethodReturnValue(
$method, $method,
$this->getResponse()->getReturnValue() $response->getReturnValue()
); );
} else { } else {
// collect request soap headers // collect request soap headers
@ -148,7 +150,7 @@ class SoapWebServiceController extends ContainerAware
/** /**
* @return \BeSimple\SoapBundle\Soap\SoapRequest * @return \BeSimple\SoapBundle\Soap\SoapRequest
*/ */
public function getRequest() protected function getRequest()
{ {
return $this->soapRequest; return $this->soapRequest;
} }
@ -156,35 +158,37 @@ class SoapWebServiceController extends ContainerAware
/** /**
* @return \BeSimple\SoapBundle\Soap\SoapResponse * @return \BeSimple\SoapBundle\Soap\SoapResponse
*/ */
public function getResponse() protected function getResponse()
{ {
return $this->soapResponse ?: $this->soapResponse = $this->container->get('besimple.soap.response'); return $this->soapResponse ?: $this->soapResponse = $this->container->get('besimple.soap.response');
} }
/** /**
* Checks that the given Response is a SoapResponse. * Set the SoapResponse
* *
* @param Response $response A response to check * @param Response $response A response to check and set
* *
* @return SoapResponse A valid SoapResponse * @return \BeSimple\SoapBundle\Soap\SoapResponse A valid SoapResponse
* *
* @throws InvalidArgumentException if the given Response is not an instance of SoapResponse * @throws InvalidArgumentException If the given Response is not an instance of SoapResponse
*/ */
protected function checkResponse(Response $response) protected function setResponse(Response $response)
{ {
if (!$response instanceof SoapResponse) { if (!$response instanceof SoapResponse) {
throw new \InvalidArgumentException('You must return an instance of BeSimple\SoapBundle\Soap\SoapResponse'); throw new \InvalidArgumentException('You must return an instance of BeSimple\SoapBundle\Soap\SoapResponse');
} }
return $response; return $this->soapResponse = $response;
} }
private function getWebServiceContext($webservice) private function getWebServiceContext($webservice)
{ {
if (!$this->container->has('besimple.soap.context.'.$webservice)) { $context = sprintf('besimple.soap.context.%s', $webservice);
throw new NotFoundHttpException(sprintf('No webservice with name "%s" found.', $webservice));
if (!$this->container->has($context)) {
throw new NotFoundHttpException(sprintf('No WebService with name "%s" found.', $webservice));
} }
return $this->container->get('besimple.soap.context.'.$webservice); return $this->container->get($context);
} }
} }